Disable use $crate::{self} like use $crate
#146972
Draft
+104
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to set assignee to
|
rustbot
added
S-waiting-on-review
ehuss
reviewed
Sep 24, 2025
compiler/rustc_resolve/messages.ftl
Outdated
| resolve_unnamed_crate_root_import = | ||
| crate root imports need to be explicitly named: `use crate as name;` | ||
| {$dollar -> | ||
| [true] crate root imports need to be explicitly named: `use $crate as name;` |
There was a problem hiding this comment.
I don't think this is a valid suggestion. Per this, use $crate as x; is not allowed.
There was a problem hiding this comment.
Though I suppose it is a separate question if that restriction makes sense if there is an as. Is there a reason to also prevent that?
There was a problem hiding this comment.
Ah yes! Updated, now will also emit $crate may not be imported for use $crate::{self} things
There was a problem hiding this comment.
The whole pre-existing logic here is garbage (#119776 (comment)), and this PR adds more.
The only restriction that we really need here is for imports to always end up with a name (*) - #35612 (comment).
use super; // bad
use super as name; // good
use super::{self}; // bad
use super::{self as name}; // good
use self; // bad
use self as name; // good
use crate; // bad
use crate as name; // good
use crate::{self}; // bad
use crate::{self as name}; // good
use $crate; // bad
use $crate as name; // good
use $crate::{self}; // bad
use $crate::{self as name}; // good
// etcMany of these examples do not work correctly atm for various reasons.
(*) The name can even be underscore _, but it will just always be reported as unused in this case.
There was a problem hiding this comment.
More than a partial fixup, I'd rather want to see an exhaustive test listing the possible cases of imports using only path segment keywords (self, super, crate, $crate) in the input path with FIXMEs as a declaration of intent.
There was a problem hiding this comment.
@mu001999
Could you add such a test?
Adding some partial fixup on top of that would also be fine, but ideally this stuff just needs to be rewritten.
There was a problem hiding this comment.
for the case use $crate as name; // good in the above examples, @ehuss said in rust-lang/reference#2010 (comment):
but for some reason use $crate as foo doesn't work either.
And I'd like to rewrite the whole logic
ehuss
added a commit
to ehuss/reference
that referenced
this pull request
Sep 24, 2025
The previous wording for this restriction was pretty confusing to me. I don't remember what I was thinking when I wrote it, and I can't find any historical explanation either. `use` paths can use `$crate` as long as they have more than one segment (`use $crate::foo` is obviously OK). I have rewritten this to make it clear it is specifically about `use $crate`. One could say that restriction is already covered by the previous point that says `use crate;` requires an `as`, but for some reason `use $crate as foo` doesn't work either. So I have left this as a separate rule for now. cc rust-lang/rust#146972 (comment) for context.
mu001999
force-pushed
the
fix/use-dollar-crate
branch
from
ce2578f to
49c425d
Compare
mu001999
changed the title
use $crate::{self} like use $crate
petrochenkov
added
S-waiting-on-author
mu001999
force-pushed
the
fix/use-dollar-crate
branch
from
49c425d to
d0d3a9d
Compare
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146967
we have hadUnnamedCrateRootImportfor things likeuse crate::self, reusing it for$crateseems good enoughEmit error
CrateImportedwhen we meetuse $crate::{self}r? petrochenkov